Browse Source

Update 'settings_form.php'

- v 1.6.2 2020/01/20
  + Avoid presence of ' and " in DB to close string to put JavaScript (avoid error)
leo 4 years ago
parent
commit
333ccda947
1 changed files with 7 additions and 3 deletions
  1. 7 3
      settings_form.php

+ 7 - 3
settings_form.php

@@ -7,6 +7,8 @@
  * then by 'ilm_handlers/(html5 or java).php' with copy_new_version_ilm($param, $files_extract)'
  * 
  * Release Notes:
+ * - v 1.6.2 2020/01/20
+ *   + Avoid presence of ' and " in DB to close string to put JavaScript (avoid error)
  * - v 1.6.1 2017/12/02
  *   + New help button, improvements on some helps, new code comments and indentation.
  * - v 1.6 2013/12/12
@@ -111,7 +113,8 @@ class mod_ilm_form extends moodleform {
     function search_name (name) {
       var i;
       var names = new Array(";
-      $code_javascript .= $names . "'');\n";
+      if ($names != '')
+        $code_javascript .= addslashes($names) . "');\n"; // if the name has ' it implies close JavaScript string => error!
       $code_javascript .= "
       for (i=0;i<names.length;i++) {
         if (names[i].toLowerCase()==name.toLowerCase()) {
@@ -144,7 +147,8 @@ class mod_ilm_form extends moodleform {
       var filejar = tmp[tmp.length-1];
 
       var filejars = new Array(";
-      $code_javascript .= $filejars . "'');" . chr(13);
+      if ($filejar!='')
+        $code_javascript .= addslashes($filejars) . "');" . chr(13); // if the name has ' it implies close JavaScript string => error!
       $code_javascript .= "
       for (i=0;i<filejars.length;i++) {
         if (filejars[i].toLowerCase()==filejar.toLowerCase()) {
@@ -337,4 +341,4 @@ class mod_ilm_form extends moodleform {
     $this->add_action_buttons();
     }
 
-  }
+  }